Skip to content

[WIP] Package torchvision with libjpeg-turbo instead of libjpeg #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NicolasHug wants to merge 24 commits into from
Closed

[WIP] Package torchvision with libjpeg-turbo instead of libjpeg #5951

NicolasHug wants to merge 24 commits into from

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 5, 2022

Follow up to #5941

NicolasHug
NicolasHug commented May 5, 2022
View reviewed changes
datumbox
datumbox reviewed May 9, 2022
View reviewed changes
packaging/pkg_helpers.bash
conda create ${CONDA_CHANNEL_FLAGS} -yn "env$PYTHON_VERSION" python="$PYTHON_VERSION"
conda activate "env$PYTHON_VERSION"
# Install libpng from Anaconda (defaults)
conda install ${CONDA_CHANNEL_FLAGS} libpng "jpeg<=9b" -y
Copy link
Contributor

@datumbox datumbox May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this script used? The jpeg<=9b is definitely stale as we no longer pin the library.

@NicolasHug NicolasHug mentioned this pull request May 9, 2022
Closed
@NicolasHug
Copy link
Member Author

NicolasHug commented May 9, 2022

Copying @datumbox's #5941 (comment) here:

If we merge this, we should test that it has no big effects on the model accuracies. We don't need to test all the models, a sample of 2-3 cases will do.

@pmeier pmeier mentioned this pull request Sep 12, 2022
Closed
@NicolasHug NicolasHug mentioned this pull request Jun 15, 2023
Merged
@NicolasHug
Copy link
Member Author

NicolasHug commented Aug 10, 2023

#7820

@NicolasHug NicolasHug closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolasHug @datumbox @facebook-github-bot @pmeier