- 
                Notifications
    
You must be signed in to change notification settings  - Fork 7.2k
 
Further enhance Classification Reference #4444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            datumbox
  merged 11 commits into
  pytorch:main
from
datumbox:references/classification_improvements
  
      
      
   
  Sep 21, 2021 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            11 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2867310
              
                Adding ExponentialLR and LinearLR
              
              
                datumbox a5b2789
              
                Merge branch 'main' into references/classification_improvements
              
              
                datumbox ae7d7e9
              
                Fix arg type of --lr-warmup-decay
              
              
                datumbox 5308098
              
                Adding support of Zero gamma BN and SGD with nesterov.
              
              
                datumbox 12357aa
              
                Fix --lr-warmup-decay for video_classification.
              
              
                datumbox e51ddb0
              
                Update bn_reinit
              
              
                datumbox 1b2dc95
              
                Fix pre-existing bug on num_classes of model
              
              
                datumbox 29615b7
              
                Remove zero gamma.
              
              
                datumbox cb7905c
              
                Use fstrings.
              
              
                datumbox d1b7046
              
                Merge branch 'main' into references/classification_improvements
              
              
                datumbox a6ba4bc
              
                Merge branch 'main' into references/classification_improvements
              
              
                datumbox File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Are there other options starting with sgd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nasty workaround to support nesterov. Instead of adding another flat
argsparameter that is useful only when SGD is selected, the user can request forsgd_nesterov.