-
Notifications
You must be signed in to change notification settings - Fork 7.2k
NOMRG Show libjpeg version when building #3968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
From the logs it looks like linux is using So they're all 9b versions clearly, but looking at https://anaconda.org/anaconda/jpeg/files?sort=time&sort_order=desc&version=9b the windows binary is 1.5 years older than the linux and the macos ones... which seems a bit fishy. It's possible that the linux/macos versions contains patches or fixes that the windows version doesn't have. CC @fmassa , any thought? |
|
That being said I still don't know how to verify which version is used by torchvision and by PIL 🤔 |
Thanks for checking this!
that is interesting. Yeah, that definitely looks suspicious.
We could probably add a method like vision/torchvision/csrc/vision.cpp Lines 25 to 30 in 21426dd
Something like torchvision.io._print_jpeg_version()But there might be an easier way if we ssh into the CI EDIT: Looks like we might want to use |
|
Thanks a lot for the help @fmassa . As we suspected, the libjpeg version on Windows CI jobs is different for PIL and for torchvision: on the linux job, it is the same: EDIT: interestingly enough: In both windows and linux we get the exact same pil version So the same pil 8.2.0 version uses a different libjpeg backend version for linux and for windows |
|
Awesome, thanks for the investigation @NicolasHug ! This means that we are consistent on our side. Maybe we can open an issue in PIL to mention that they use different versions of libjpeg depending on the OS? |
|
Oh: On windows: On linux: |
|
Closing this, I followed up in #3913 |
No description provided.