Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing unitest warnings #820

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixing unitest warnings #820

wants to merge 2 commits into from

Conversation

ccharest93
Copy link
Contributor

Went through the warning list from pytest and tryed to fix as many warning as i could that should not be raised within testing.
This allows relevant warnings to not be lost within a lot of irrelevant warnings.
I didn't touch the KFP, ray and kubernetes warnings, i will leave those to people with more contextual knowledge.

Fixes included:

  • remediation for deprecation
  • catching warnings if they are expected to be thrown
  • renaming of test helper functions/class that were being picked up wrongly by unitest (names starting with test)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccharest93 @facebook-github-bot