Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-requirements: bump kfp version to 1.8.22 to fix PyYaml issue #747

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Jul 26, 2023

Work around the PyYaml+cython issue in yaml/pyyaml#601 by bumping kfp version to no longer need pyyaml<6.0

Test plan:

CI

pip install -r dev-requirements.txt

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2023
@d4l3k d4l3k requested a review from kiukchung July 26, 2023 06:49
@d4l3k d4l3k added the dependencies Pull requests that update a dependency file label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #747 (318bfff) into main (a17e427) will increase coverage by 1.74%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   91.06%   92.80%   +1.74%     
==========================================
  Files          96       96              
  Lines        6063     6071       +8     
==========================================
+ Hits         5521     5634     +113     
+ Misses        542      437     -105     
Flag Coverage Δ
unittests 92.80% <ø> (+1.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d4l3k
Copy link
Member Author

d4l3k commented Jul 26, 2023

Python 3.10 unit tests passing now -- landing

@d4l3k d4l3k merged commit 83268d6 into main Jul 26, 2023
20 of 22 checks passed
@d4l3k d4l3k deleted the fix-pyyaml branch July 26, 2023 07:02
KPostOffice pushed a commit to KPostOffice/torchx that referenced this pull request Sep 7, 2023
MichaelClifford pushed a commit to project-codeflare/torchx that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants