Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: aws_batch/kfp fix dead links + change user agent to avoid 403 #746

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Jul 26, 2023

Fixes linkcheck in docs build

sphinx-doc/sphinx#1331

Test plan:

SKIP_NB=1 make -C docs linkcheck

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2023
@d4l3k d4l3k requested a review from kiukchung July 26, 2023 06:46
@d4l3k d4l3k added the documentation Improvements or additions to documentation label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #746 (b091834) into main (a17e427) will increase coverage by 1.64%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   91.06%   92.70%   +1.64%     
==========================================
  Files          96       96              
  Lines        6063     6062       -1     
==========================================
+ Hits         5521     5620      +99     
+ Misses        542      442     -100     
Flag Coverage Δ
unittests 92.70% <ø> (+1.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
torchx/pipelines/kfp/adapter.py 98.52% <ø> (ø)
torchx/schedulers/aws_batch_scheduler.py 89.93% <ø> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d4l3k
Copy link
Member Author

d4l3k commented Jul 26, 2023

docs passing

@d4l3k d4l3k merged commit 7b59f67 into main Jul 26, 2023
19 of 22 checks passed
@d4l3k d4l3k deleted the fix-doc-link branch July 26, 2023 07:01
MichaelClifford pushed a commit to project-codeflare/torchx that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants