Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchX | GCP Batch] Support list operation #650

Closed
wants to merge 1 commit into from
Closed

Conversation

priyaramani
Copy link
Contributor

@priyaramani priyaramani commented Nov 8, 2022

Support list operation to list jobs names and their statuses for batch jobs launched in the GCP project

Part of #410

Test plan:
Unittests
Screen Shot 2022-11-08 at 11 49 44 AM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 8, 2022
@facebook-github-bot
Copy link
Contributor

@priyaramani has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #650 (e1791c8) into main (d0519af) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   94.56%   94.55%   -0.01%     
==========================================
  Files          71       71              
  Lines        5041     5055      +14     
==========================================
+ Hits         4767     4780      +13     
- Misses        274      275       +1     
Impacted Files Coverage Δ
torchx/schedulers/gcp_batch_scheduler.py 92.90% <83.33%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

@priyaramani has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

priyaramani added a commit that referenced this pull request Nov 8, 2022
Summary:
Support list operation to list jobs names and their statuses for batch jobs launched in the GCP project

Pull Request resolved: #650

Test Plan:
Unittests
![Screen Shot 2022-11-08 at 11 49 44 AM](https://user-images.githubusercontent.com/87679608/200661445-7accc09e-2411-4a95-9053-0eb3907c002e.png)

Differential Revision: D41132440

Pulled By: priyaramani

fbshipit-source-id: 1ed52d06156efffa2e346d12d1f3ae01d875334a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41132440

priyaramani added a commit that referenced this pull request Nov 11, 2022
Summary:
Support list operation to list jobs names and their statuses for batch jobs launched in the GCP project

Pull Request resolved: #650

Test Plan:
Unittests
![Screen Shot 2022-11-08 at 11 49 44 AM](https://user-images.githubusercontent.com/87679608/200661445-7accc09e-2411-4a95-9053-0eb3907c002e.png)

Differential Revision: D41132440

Pulled By: priyaramani

fbshipit-source-id: f2d5cf3fc742ab6e3949e37679c9819d78a824bf
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41132440

priyaramani added a commit that referenced this pull request Nov 11, 2022
Summary:
Support list operation to list jobs names and their statuses for batch jobs launched in the GCP project

Pull Request resolved: #650

Test Plan:
Unittests
![Screen Shot 2022-11-08 at 11 49 44 AM](https://user-images.githubusercontent.com/87679608/200661445-7accc09e-2411-4a95-9053-0eb3907c002e.png)

Differential Revision: D41132440

Pulled By: priyaramani

fbshipit-source-id: f1ca51938987297b3fbc872f12d1d7da185ae26a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41132440

Summary:
Support list operation to list jobs names and their statuses for batch jobs launched in the GCP project

Pull Request resolved: #650

Test Plan:
Unittests
![Screen Shot 2022-11-08 at 11 49 44 AM](https://user-images.githubusercontent.com/87679608/200661445-7accc09e-2411-4a95-9053-0eb3907c002e.png)

Differential Revision: D41132440

Pulled By: priyaramani

fbshipit-source-id: 7026f5e391ca1e69731e9930112e34d5f60501b9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41132440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants