Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchX | GCP Batch] Support cancel operation #649

Closed
wants to merge 1 commit into from
Closed

Conversation

priyaramani
Copy link
Contributor

@priyaramani priyaramani commented Nov 7, 2022

[TorchX | GCP Batch] Support cancel operation

Part of #410

Test plan: Unit tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2022
@facebook-github-bot
Copy link
Contributor

@priyaramani has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #649 (3e74d33) into main (ec4060d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   94.51%   94.56%   +0.04%     
==========================================
  Files          71       71              
  Lines        5031     5039       +8     
==========================================
+ Hits         4755     4765      +10     
+ Misses        276      274       -2     
Impacted Files Coverage Δ
torchx/schedulers/gcp_batch_scheduler.py 92.80% <100.00%> (+2.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

priyaramani added a commit that referenced this pull request Nov 8, 2022
Summary:
[TorchX | GCP Batch] Support cancel operation

Pull Request resolved: #649

Test Plan: Unit tests

Differential Revision: D41091647

Pulled By: priyaramani

fbshipit-source-id: 936b394f95785f758943db7dc0553d4505248eea
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41091647

Summary:
[TorchX | GCP Batch] Support cancel operation

Pull Request resolved: #649

Test Plan: Unit tests

Differential Revision: D41091647

Pulled By: priyaramani

fbshipit-source-id: bf17d16e5cfbcb5915650bc3c220e011fb06c15e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41091647

priyaramani added a commit that referenced this pull request Nov 8, 2022
Summary:
[TorchX | GCP Batch] Support cancel operation

Pull Request resolved: #649

Test Plan: Unit tests

Differential Revision: https://www.internalfb.com/diff/D41091647?entry_point=27

Pulled By: priyaramani

fbshipit-source-id: 6fd1709d67548e1f48743db43181c4583a31e165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants