Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: change torchx color to blue and fix for closed stdout #419

Closed
wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Contributor

@d4l3k d4l3k commented Mar 11, 2022

Fixes #418.
Fixes #413.

This changes the torchx logo color to blue since the PT orange can be confused with an red error message and fixes a bug where isatty fails due to stdout being closed in strange environments.

Color choices:

  • red/orange - too close to error colors
  • green - already used by log role/rank prefixes
  • purple - clashes with green
  • blue - neutral/meta
  • cyan - a little too bright (backup if blue is too dark)
  • black - no
  • brown - ick
  • gray - already used for timestamps
  • white - user feedback is colors are good :)

Test plan:

2022-03-11-122158_1090x138_scrot

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2022
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #419 (94c16b0) into main (2d3a981) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   94.20%   94.17%   -0.03%     
==========================================
  Files          66       66              
  Lines        3690     3692       +2     
==========================================
+ Hits         3476     3477       +1     
- Misses        214      215       +1     
Impacted Files Coverage Δ
torchx/cli/colors.py 58.33% <66.66%> (-1.67%) ⬇️
torchx/cli/main.py 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3a981...94c16b0. Read the comment docs.

@d4l3k d4l3k added this to the 0.1.2 release milestone Mar 22, 2022
@d4l3k d4l3k deleted the colors branch April 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli/colors: crash when importing if sys.stdout is closed change torchx logo coloring in terminal
2 participants