slurm_scheduler, dir_workspace: add isolated workspaces for Slurm #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 94.20% 94.28% +0.08%
==========================================
Files 66 67 +1
Lines 3690 3761 +71
==========================================
+ Hits 3476 3546 +70
- Misses 214 215 +1
Continue to review full report at Codecov.
|
d4l3k
force-pushed
the
slurmimp
branch
2 times, most recently
from
f91cfbf
to
9b60e81
Compare
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d4l3k
added a commit
that referenced
this pull request
Mar 11, 2022
Summary: This adds a new `DirWorkspace` which will copy the current workspace to the directory for code isolation purposes and integrates it in with the `slurm` scheduler via the `job_dir` runopt. The job dir must not exist and will be created. The CWD will be located in that job_dir. * `.torchxignore` is used for excluding files from the workspace * `.torchxslurmjobdirs` is used to track where job directories and thus logs are located Pull Request resolved: #416 Test Plan: Slurm integ tests + unit tests Reviewed By: kiukchung Differential Revision: D34801126 Pulled By: d4l3k fbshipit-source-id: 7423897d4a372f524230d08bc681493c112ce383
|
This pull request was exported from Phabricator. Differential Revision: D34801126 |
Summary: This adds a new `DirWorkspace` which will copy the current workspace to the directory for code isolation purposes and integrates it in with the `slurm` scheduler via the `job_dir` runopt. The job dir must not exist and will be created. The CWD will be located in that job_dir. * `.torchxignore` is used for excluding files from the workspace * `.torchxslurmjobdirs` is used to track where job directories and thus logs are located Pull Request resolved: #416 Test Plan: Slurm integ tests + unit tests Reviewed By: kiukchung Differential Revision: D34801126 Pulled By: d4l3k fbshipit-source-id: d53f6f36ad76921289116ee3e8a7c05b0975e594
|
This pull request was exported from Phabricator. Differential Revision: D34801126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
DirWorkspacewhich will copy the current workspace to the directory for code isolation purposes and integrates it in with theslurmscheduler via thejob_dirrunopt. The job dir must not exist and will be created. The CWD will be located in that job_dir..torchxignoreis used for excluding files from the workspace.torchxslurmjobdirsis used to track where job directories and thus logs are locatedTest plan:
Slurm integ tests + unit tests