Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(torchx/cli) load .torchxconfig file from HOME -> CWD for cmd_run #378

Closed
wants to merge 1 commit into from
Closed

(torchx/cli) load .torchxconfig file from HOME -> CWD for cmd_run #378

wants to merge 1 commit into from

Conversation

kiukchung
Copy link
Collaborator

Summary:
Adds $HOME to the list of dirs where we search for .torchxconfig.

$HOME/.torchxconfig takes precedence over $CWD/.torchxconfig

Reviewed By: d4l3k

Differential Revision: D33858048

Summary:
Adds `$HOME` to the list of dirs where we search for .torchxconfig.

$HOME/.torchxconfig takes precedence over $CWD/.torchxconfig

Reviewed By: d4l3k

Differential Revision: D33858048

fbshipit-source-id: 6a3dc385bdbcb219f9f0dd83fa110c2636216f04
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jan 29, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33858048

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #378 (299ead1) into main (9d8c74d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   94.66%   94.73%   +0.06%     
==========================================
  Files          61       61              
  Lines        3227     3229       +2     
==========================================
+ Hits         3055     3059       +4     
+ Misses        172      170       -2     
Impacted Files Coverage Δ
torchx/cli/cmd_run.py 90.84% <100.00%> (+0.13%) ⬆️
torchx/schedulers/docker_scheduler.py 97.20% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8c74d...299ead1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants