Skip to content

Improve RoPE documentation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

Improve RoPE documentation #4

merged 1 commit into from
Oct 26, 2023

Conversation

kartikayk
Copy link
Contributor

Summary:

Adding more comments to the RoPE documentation. This should improve readability.

Test Plan

Unit Tests succeeded. Run unit tests using:

cd ~/torch_tbd/tests/llm/llama2

pytest

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2023
@kartikayk kartikayk merged commit 7e2bb6f into main Oct 26, 2023
@kartikayk kartikayk deleted the rope_docs branch October 26, 2023 15:30
joecummings pushed a commit that referenced this pull request May 1, 2025
@felipemello1
Merge pull request #4 from joecummings/add_profiler
7b056f4 
profiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecummings joecummings Awaiting requested review from joecummings

1 more reviewer

@rohan-varma rohan-varma rohan-varma approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartikayk @rohan-varma @facebook-github-bot