added extra check in __del__

[felipemello1]

Context

What is the purpose of this PR? Is it to

• add a new feature
• fix a bug
• update tests and/or documentation
• other (please add here)

see #1298 for context

Changelog

just add extra check

Test plan

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1322

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dc522b3 with merge base 0531dcb ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[SalmanMohammadi]

Going to be annoying - can you confirm correct error is raised when wandb isn't installed, please?
Or add a unit test? : )

[joecummings]

Going to be annoying - can you confirm correct error is raised when wandb isn't installed, please? Or add a unit test? : )

One of us!!!!

[SalmanMohammadi]

[felipemello1]

(╯°□°）╯︵ ┻━┻

[felipemello1]

@joecummings @SalmanMohammadi good call :P fixed it

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.56%. Comparing base (6be89c0) to head (dc522b3).
Report is 3 commits behind head on main.

Files	Patch %	Lines
torchtune/utils/metric_logging.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
- Coverage   68.57%   68.56%   -0.01%     
==========================================
  Files         258      258              
  Lines       11972    11975       +3     
==========================================
+ Hits         8210     8211       +1     
- Misses       3762     3764       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joecummings]

STAMP