add TensorBoard logging with loss and wps #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Feb 13, 2024
ghstack-source-id: 297bec2b7acdf83c0af32dbf89dda3c6672095c9 Pull Request resolved: #57
facebook-github-bot
added
the
CLA Signed
Closed
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Feb 13, 2024
ghstack-source-id: cdfe4c2c496feae23399019ec2a63b443fb3b6a9 Pull Request resolved: #57
wanchaol
reviewed
Feb 14, 2024
train.py
Outdated
|
|
||
| time_delta = timer() - time_last_log | ||
| wps = nwords_since_last_log / ( | ||
| time_delta * parallel_dims.sp * parallel_dims.pp |
There was a problem hiding this comment.
a neater way is to define a model_parallel_size in the parallel_dims class that return this number directly (i.e. a cached property)
wanchaol
approved these changes
Feb 14, 2024
Each rank build its own TensorBoard writer. The global loss is communicated among all ranks before logging. To visualize using SSH tunneling: `ssh -L 6006:127.0.0.1:6006 your_user_namemy_server_ip` in torchtrain repo `tensorboard --logdir=./torchtrain/outputs/tb` then on web browser go to http://localhost:6006/ <img width="722" alt="Screenshot 2024-02-12 at 6 39 28 PM" src="https://github.com/pytorch-labs/torchtrain/assets/150487191/6304103c-fa89-4f1c-a8a2-57c887b07cd3"> [ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Feb 15, 2024
ghstack-source-id: d0828f16c06747a5af2586630e5205bf786de1c4 Pull Request resolved: #57
tianyu-l
added a commit
that referenced
this pull request
Feb 15, 2024
ghstack-source-id: d0828f16c06747a5af2586630e5205bf786de1c4 Pull Request resolved: #57
lessw2020
pushed a commit
that referenced
this pull request
Apr 18, 2024
ghstack-source-id: d0828f16c06747a5af2586630e5205bf786de1c4 Pull Request resolved: #57
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
ghstack-source-id: d0828f16c06747a5af2586630e5205bf786de1c4 Pull Request resolved: pytorch#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Each rank build its own TensorBoard writer. The global loss is communicated among all ranks before logging.
To visualize using SSH tunneling:
ssh -L 6006:127.0.0.1:6006 your_user_name@my_server_ipin torchtrain repo
tensorboard --logdir=./torchtrain/outputs/tbthen on web browser go to http://localhost:6006/