-
Notifications
You must be signed in to change notification settings - Fork 632
Integrate DeepEP to torchtitan #2107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elfiegg
wants to merge
8
commits into
pytorch:main
Choose a base branch
from
elfiegg:loss_bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+799
−17
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cadd426
Integrate DeepEP to experimental torchtitan
elfiegg 447d881
Revise per discussion
elfiegg 775b5be
Add deepep folder..
elfiegg 1802b49
add async - nccl coalesce takes very long
elfiegg 4a65d60
revise per disscussion round 2, add SAC and optional padding
elfiegg 1c137d6
clean up
elfiegg db455a3
one more cleanup
elfiegg 0dddde8
convert scores not hidden states; saves ~10G memory
elfiegg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,9 +13,14 @@ | |
| from torch.distributed.tensor.placement_types import Placement | ||
|
|
||
| from torchtitan.distributed.parallel_dims import ParallelDims | ||
| from torchtitan.distributed.expert_parallel import DeepEPExpertParallel | ||
|
|
||
|
|
||
| __all__ = ["ParallelDims", "NoParallel"] | ||
| __all__ = [ | ||
| "ParallelDims", | ||
| "NoParallel", | ||
| "DeepEPExpertParallel", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's not expose this here for now |
||
| ] | ||
|
|
||
|
|
||
| # NOTE: This is to achieve replicate computation on the gate module in the MoE router. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # All rights reserved. | ||
| # | ||
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| """DeepEP distributed communication primitives for MoE.""" | ||
|
|
||
| from .deepep import ( | ||
| dispatch_tokens, | ||
| combine_tokens, | ||
| DispatchState, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "dispatch_tokens", | ||
| "combine_tokens", | ||
| "DispatchState", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is optional? IIUC this is must in order to use torch._grouped_mm.