add varlen attention for qwen 3 #2084
Merged
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
liangel-02
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
wwwjn
reviewed
Nov 25, 2025
Contributor
wwwjn
left a comment
wwwjn
left a comment
There was a problem hiding this comment.
LGTM! A random question about the loss - Why they are not identical? Is it because bot Flex and Varlen attention are compiled to be different kennels so they don't have numerics guarantee? If we don't compile the attention (bare the low efficiency), will the numerics be the same
tianyu-l
reviewed
Nov 25, 2025
Contributor
|
also need to add sac support for Qwen3 varlen |
Contributor
Author
drisspg
approved these changes
Nov 25, 2025
tianyu-l
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
Testing
performance and loss on par