Print out the version number #2083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Nov 24, 2025
meta-cla
bot
added
the
CLA Signed
tianyu-l
reviewed
Nov 24, 2025
torchtitan/train.py
Outdated
|
|
||
| import torchtitan | ||
| logger.info( | ||
| "TorchTitan version: %s (0.0.0 means __version__ is not defined correctly).", |
Contributor
There was a problem hiding this comment.
when would it be not defined?
can we just put Undefined instead of 0.0.0 as the version, so that we don't need to explain even when the version is normal?
Contributor
Author
There was a problem hiding this comment.
I believe "undefined" is going to break some package installation. We can do "0.0.0+unknown". But the explanation is better to stay there for people who don't know the version restriction well.
fegin
added a commit
that referenced
this pull request
Nov 24, 2025
fegin
added a commit
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR and #2070 can resolve #2043.
This should not affect
.github/scripts/update_version.shas.github/scripts/update_version.shwill append the version at the end of the file, which will overwrite the value.