[RFC] Seperate init_distributed_env from the Trainer.__init__ #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows people to customize the distributed environment, including ParallelDims and distributed backend
meta-cla
bot
added
the
CLA Signed
tianyu-l
reviewed
Nov 7, 2025
| parallel_dims: TorchCommsParallelDims | ||
|
|
||
| def _create_parallel_dims(self, parallelism_config, world_size) -> ParallelDims: | ||
| def init_distributed_env(self, job_config: JobConfig) -> ParallelDims: |
Contributor
There was a problem hiding this comment.
This PR doesn't do anything new with distributed backend. Are you saying we will modify this code for torchcomms?
Asking because I'm a bit concerned about sending whole job_config to this function, which seems a regression in terms of config usage hygiene.
Contributor
Author
|
This is to unblock the case where people who need to subclass trainer to customize the distributed environment, which includes both TorchCOMM and TorchFT. Unfortunately, it seems that initializing the distributed environment requires more configurations from different configurations. So there is no single sub configuration is enough. But I shouldn't pass job_config as it is a method and can access job_config anyway. |
jquesnelle
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Nov 10, 2025
…h#2003) This allows people to customize the distributed environment, including ParallelDims and distributed backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to customize the distributed environment, including ParallelDims and distributed backend.