An alternative implementation of torchrec serializer #2166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58933792 |
Summary: Pull Request resolved: #2166 # context * after discussion with dstaay-fb, a rule of thumb: serializer APIs better to be symmetric * `SerializerInterface.serialize` takes a target module (nn.Module, usually sparse), returns a tensor (serialized binary, will be put to a buffer), and a list of child_fqns, which require further serialization * `SerializerInterface.deserialize` takes the binary data (tensor from buffer), a device flag, and the unflattened module (for its child modules), returns the deserialized module * the main APIs for external usage are the `serialize_embedding_modules` and `_deserialize_embedding_modules` * the former walks through the input module, finds the sparse (sub)modules, stores sparse modules metadata in buffer * the later walks through the input module (unflattened from ep), finds the stored metadata from the buffer, and restore the sparse modules. Differential Revision: D58933792
|
This pull request was exported from Phabricator. Differential Revision: D58933792 |
TroyGarden
force-pushed
the
export-D58933792
branch
from
ff7e793 to
cd1d480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
SerializerInterface.serializetakes a target module (nn.Module, usually sparse), returns a tensor (serialized binary, will be put to a buffer), and a list of child_fqns, which require further serializationSerializerInterface.deserializetakes the binary data (tensor from buffer), a device flag, and the unflattened module (for its child modules), returns the deserialized moduleserialize_embedding_modulesand_deserialize_embedding_modulesDifferential Revision: D58933792