Fix pts -> index conversion in get_frame_at_timestamps[_in_range]
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Oct 24, 2024
| stop_seconds=all_pts_seconds_ref[-1] + 1e-4, | ||
| ) | ||
| assert_tensor_equal(pts_seconds, all_pts_seconds_ref) | ||
|
|
There was a problem hiding this comment.
Note: all test-cases above were passing on main.
The ones below this line were failing. We never caught the one on get_frames_by_pts_in_range because it was only triggered when start_seconds was later than the second-to-last frame. And the error message is quite.... interesting!
def __call__(self, /, *args, **kwargs):
> return self._op(*args, **kwargs)
E RuntimeError: Trying to create tensor with negative dimension -1: [-1, 270, 480, 3]
|
Just commenting to chime in on the actual merged PR that is is a great catch. Thanks for fixing my bug. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the bug described in #286. We use a sightly different solution as suggested in #286 (comment).
This PR fixes the behavior of both
get_frame_at_timestamps()andget_frames_at_timestamps_in_range().