Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substitute llama3 tokenizer path for stories15M tokenizer on-pr #697

Closed
wants to merge 1 commit into from
Closed

substitute llama3 tokenizer path for stories15M tokenizer on-pr #697

wants to merge 1 commit into from

Conversation

mikekgfb
Copy link
Contributor

@mikekgfb mikekgfb commented May 6, 2024

substitute llama3 tokenizer path for stories15M tokenizer on-pr

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 6, 2024
malfet
malfet approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how it helps validating the doc, but sure, why not

@mikekgfb
Copy link
Contributor Author

mikekgfb commented May 6, 2024

Not sure how it helps validating the doc, but sure, why not

Huh? We're peeling out all the commands and running them.
Now you could say we're running stories15M but llama3, so it's not truly validating. But that might be said of all the on-pr tests using stories15M, then.

@mikekgfb mikekgfb closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikekgfb @malfet @facebook-github-bot