Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aoti calls to utilize new export and packaging APIs #1455

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

angelayi
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Jan 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1455

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0fa1570 with merge base f4ae60f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 10, 2025
torchchat/export.py Outdated Show resolved Hide resolved
@angelayi angelayi force-pushed the angelayi/aoti_api_update branch from 68eda92 to 9fb3007 Compare January 10, 2025 17:56
@angelayi angelayi force-pushed the angelayi/aoti_api_update branch from 9fb3007 to 73739bd Compare January 10, 2025 19:14
@angelayi angelayi marked this pull request as ready for review January 10, 2025 19:15
@Jack-Khuu
Copy link
Contributor

Jack-Khuu commented Jan 15, 2025

Thanks for the update, mind adding a bit of context to the description?

Looks like the error is legit? An arg mismatch

Edit: some of the ET ones are not related and are being tackled in #1459

@Jack-Khuu Jack-Khuu self-requested a review January 15, 2025 19:34
@Jack-Khuu Jack-Khuu added the Compile / AOTI Issues related to AOT Inductor and torch compile label Jan 15, 2025
@Jack-Khuu Jack-Khuu changed the title Update aoti APIs Update aoti calls to utilize new export and packaging APIs Jan 24, 2025
@Jack-Khuu Jack-Khuu merged commit 5cd6579 into main Jan 24, 2025
62 checks passed
vmpuri pushed a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. Compile / AOTI Issues related to AOT Inductor and torch compile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants