Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Minor typo + Update install_requirements.sh to support python 3.10 >= #1368

Merged
Gasoonjia merged 4 commits into from
Nov 13, 2024
Merged

Minor typo + Update install_requirements.sh to support python 3.10 >= #1368

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1335e09
Update install_requirements.sh to support python 3.10 >= , <3.13
Jack-Khuu Nov 12, 2024
803c41e
Update install_requirements.sh
Jack-Khuu Nov 13, 2024
988e8a5
Merge branch 'main' into Jack-Khuu-patch-25
Jack-Khuu Nov 13, 2024
a2917ea
Update install_requirements.sh
Jack-Khuu Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions install/install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,21 @@ then
if [[ -z ${CONDA_DEFAULT_ENV:-} ]] || [[ ${CONDA_DEFAULT_ENV:-} == "base" ]] || [[ ! -x "$(command -v python)" ]];
then
PYTHON_EXECUTABLE=python3
else
PYTHON_EXECUTABLE=python
fi
fi
echo "Using python executable: $PYTHON_EXECUTABLE"

PYTHON_SYS_VERSION="$($PYTHON_EXECUTABLE -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')")"
# Check python version. Expect 3.10.x or 3.11.x
# Check python version. Expect greater than 3.10.x
Copy link
Contributor

@Gasoonjia Gasoonjia Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

word and code below seem mismatch -- here we say greater than 3.10.x, but the code below is for greater than or equlal to 3.10

Copy link
Contributor Author

@Jack-Khuu Jack-Khuu Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated wording

if ! $PYTHON_EXECUTABLE -c "
import sys
if sys.version_info < (3, 10) or sys.version_info >= (3, 12):
if sys.version_info < (3, 10):
sys.exit(1)
";
then
echo "Python version must be 3.10.x or 3.11.x. Detected version: $PYTHON_SYS_VERSION"
echo "Python version must be greater than 3.10.x. Detected version: $PYTHON_SYS_VERSION"
exit 1
fi

Expand Down
Loading