Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.compile deps regression /torchchat fails to pin dependencies #728

Closed
malfet opened this issue May 9, 2024 · 2 comments
Closed

torch.compile deps regression /torchchat fails to pin dependencies #728

malfet opened this issue May 9, 2024 · 2 comments

Comments

@malfet
Copy link
Contributor

malfet commented May 9, 2024

I.e. all --compile linux job will fail with unterminated string literal for example see re-run of https://github.com/pytorch/torchchat/actions/runs/9006593274/job/24756706517 which previously passed

@malfet
Copy link
Contributor Author

malfet commented May 9, 2024

Tentatively fixed by #728 that adds logic to uninstall triton before installing nightly build of Torch, that depends on pytorch-triton which is just an alias for the same package name

@orionr
Copy link
Contributor

orionr commented May 15, 2024

Fixed? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants