Skip to content

Commit

Permalink
Update run-readme-pr.yml (#705)
Browse files Browse the repository at this point in the history
* Update run-readme-pr.yml

* Update run-readme-pr-macos.yml

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Replace tokenizer path as well

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
  • Loading branch information
larryliu0820 authored May 6, 2024
1 parent 5e0da2b commit 150d4ce
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 11 deletions.
15 changes: 7 additions & 8 deletions .github/workflows/run-readme-pr-macos.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Run the README instructions - with stories - on MacOS
on:
name: Run the README instructions - with stories - on MacOS
on:
pull_request:
push:
branches:
Expand All @@ -26,20 +26,20 @@ jobs:
# as this script does not isntall anything into conda env but rather as system dep
pip3 uninstall -y torch || true
set -eou pipefail
echo "::group::Print machine info"
uname -a
sysctl machdep.cpu.brand_string
sysctl machdep.cpu.core_count
echo "::endgroup::"
# echo "::group::Install newer objcopy that supports --set-section-alignment"
# yum install -y devtoolset-10-binutils
# export PATH=/opt/rh/devtoolset-10/root/usr/bin/:$PATH
# echo "::endgroup::"
echo "::group::Create script"
python3 scripts/updown.py --file README.md --replace llama3:stories15M --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
python3 scripts/updown.py --file README.md --replace 'llama3:stories15M,-l 3:-l 2,meta-llama/Meta-Llama-3-8B-Instruct:stories15M' --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
# for good measure, if something happened to updown processor,
# and it did not error out, fail with an exit 1
echo "exit 1" >> ./we-run-this.sh
Expand All @@ -50,8 +50,7 @@ jobs:
cat ./we-run-this.sh
echo "*******************************************"
bash -x ./we-run-this.sh
echo "tests complete"
echo "*******************************************"
echo "::endgroup::"

6 changes: 3 additions & 3 deletions .github/workflows/run-readme-pr.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Run the README instructions - with stories
name: Run the README instructions - with stories

on:
pull_request:
Expand Down Expand Up @@ -26,7 +26,7 @@ jobs:
# echo "::endgroup::"
echo "::group::Create script"
python3 scripts/updown.py --file README.md --replace llama3:stories15M --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
python3 scripts/updown.py --file README.md --replace 'llama3:stories15M,-l 3:-l 2,meta-llama/Meta-Llama-3-8B-Instruct:stories15M' --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
# for good measure, if something happened to updown processor,
# and it did not error out, fail with an exit 1
echo "exit 1" >> ./we-run-this.sh
Expand All @@ -37,7 +37,7 @@ jobs:
cat ./we-run-this.sh
echo "*******************************************"
bash -x ./we-run-this.sh
echo "tests complete"
echo "*******************************************"
echo "::endgroup::"

0 comments on commit 150d4ce

Please sign in to comment.