avoid compiling compute_loss #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48581289 |
|
This pull request was exported from Phabricator. Differential Revision: D48581289 |
galrotem
added a commit
to galrotem/tnt
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: pytorch#511 # Context As per discussion in D48361308, looks like we can remove this since it's only used for torch dynamo but it's not officially supported # This diff Separating the change from the above since we also need to clean up some existing UTs which don't make sense anymore. Going to rebase the above change on top of this Differential Revision: D48581289 fbshipit-source-id: 2808db907b77af373234a12d70c1314217635945
galrotem
force-pushed
the
export-D48581289
branch
from
cfd8d67 to
b674c37
Compare
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 86.95% 87.12% +0.17%
==========================================
Files 106 106
Lines 8407 8363 -44
==========================================
- Hits 7310 7286 -24
+ Misses 1097 1077 -20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D48581289 |
galrotem
added a commit
to galrotem/tnt
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: pytorch#511 # Context As per discussion in D48361308, looks like we can remove this since it's only used for torch dynamo but it's not officially supported # This diff Separating the change from the above since we also need to clean up some existing UTs which don't make sense anymore. Going to rebase the above change on top of this Differential Revision: D48581289 fbshipit-source-id: 272c8d9e8a534b6f148b06bfa1797ea81b3bcd8a
galrotem
force-pushed
the
export-D48581289
branch
from
b674c37 to
afa2a9c
Compare
Summary: Pull Request resolved: pytorch#511 # Context As per discussion in D48361308, looks like we can remove this since it's only used for torch dynamo but it's not officially supported # This diff Separating the change from the above since we also need to clean up some existing UTs which don't make sense anymore. Going to rebase the above change on top of this Reviewed By: JKSenthil Differential Revision: D48581289 fbshipit-source-id: 94219fa45190467b6b87533500f66735a909d1cb
|
This pull request was exported from Phabricator. Differential Revision: D48581289 |
galrotem
force-pushed
the
export-D48581289
branch
from
afa2a9c to
05537e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
[Describe motivations and existing situation that led to creating this diff. Don't be cheap with context, it is the basis for a good code review.]
This diff
[List all the changes that this diff introduces and explain the ones that are not trivial. Give directions for the reviewer if needed.]
What’s next
[If this diff is part of a stack or if it has direct continuation in a future diff, share these plans with your reviewer.]
Differential Revision: D48581289