Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indent bug in test_auto_unit #507

Closed
wants to merge 1 commit into from

Conversation

galrotem
Copy link
Contributor

Summary:

Context

I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

This diff

Fix redundant indentation

Differential Revision: D48478812

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #507 (8f9e25d) into master (95f6944) will not change coverage.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files         106      106           
  Lines        8407     8407           
=======================================
  Hits         7310     7310           
  Misses       1097     1097           
Files Changed Coverage Δ
tests/framework/test_auto_unit.py 71.71% <28.57%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

galrotem added a commit to galrotem/tnt that referenced this pull request Aug 18, 2023
Summary:
Pull Request resolved: pytorch#507

# Context
I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

# This diff
Fix redundant indentation

Reviewed By: JKSenthil

Differential Revision: D48478812

fbshipit-source-id: 066c3f360eac6e6474d98363f79cbbbb4a40e0d3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

galrotem added a commit to galrotem/tnt that referenced this pull request Aug 18, 2023
Summary:
Pull Request resolved: pytorch#507

# Context
I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

# This diff
Fix redundant indentation

Reviewed By: JKSenthil

Differential Revision: D48478812

fbshipit-source-id: ca650017486b84f1635fb70f35e405e0ba1f39e1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

galrotem added a commit to galrotem/tnt that referenced this pull request Aug 18, 2023
Summary:
Pull Request resolved: pytorch#507

# Context
I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

# This diff
Fix redundant indentation

Reviewed By: JKSenthil

Differential Revision: D48478812

fbshipit-source-id: 4e483a5f498ac41ff728f1425524b8c2b8599002
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

galrotem added a commit to galrotem/tnt that referenced this pull request Aug 18, 2023
Summary:
Pull Request resolved: pytorch#507

# Context
I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

# This diff
Fix redundant indentation

Reviewed By: JKSenthil

Differential Revision: D48478812

fbshipit-source-id: bb2fa1af2584fc7cfca6ec3d6ae0f8a5cf7ff235
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

galrotem added a commit to galrotem/tnt that referenced this pull request Aug 18, 2023
Summary:
Pull Request resolved: pytorch#507

# Context
I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

# This diff
Fix redundant indentation

Reviewed By: JKSenthil

Differential Revision: D48478812

fbshipit-source-id: 906e15cfc56115033c2696a693e7d6952f5370b1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

galrotem added a commit to galrotem/tnt that referenced this pull request Aug 18, 2023
Summary:
Pull Request resolved: pytorch#507

# Context
I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

# This diff
Fix redundant indentation

Reviewed By: JKSenthil

Differential Revision: D48478812

fbshipit-source-id: 73e08bd789d6d89e5e29f960664245376c1be560
Summary:
bypass-github-export-checks

Pull Request resolved: pytorch#507

# Context
I'm working to fix torchtnt pyre targets (coming up in next change) and discovered this bug

# This diff
Fix redundant indentation

Reviewed By: JKSenthil

Differential Revision: D48478812

fbshipit-source-id: 1991aba9555d61c5a1b1d1aeef2f8cff81817c41
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48478812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants