Set default value for max_steps in _is_epoch_done util #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In evaluate and predict the user does not pass in a max_steps argument so it may seem strange that `state.max_steps` is used here: https://github.com/pytorch/tnt/blob/master/torchtnt/framework/evaluate.py#L143 Removing this for better readability Differential Revision: D48198032 fbshipit-source-id: 1533ec73d5b3a84a3c7eff6c7daeb9b722fcfbdf
|
This pull request was exported from Phabricator. Differential Revision: D48198032 |
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 102 102
Lines 8337 8337
=======================================
Hits 7246 7246
Misses 1091 1091
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In evaluate and predict the user does not pass in a max_steps argument so it may seem strange that
state.max_stepsis used here: https://github.com/pytorch/tnt/blob/master/torchtnt/framework/evaluate.py#L143Removing this for better readability
Differential Revision: D48198032