replace warning w/ hard error in AutoUnit's fsdp + torch compile #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D47473960 |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 86.96% 86.95% -0.02%
==========================================
Files 104 104
Lines 8386 8387 +1
==========================================
Hits 7293 7293
- Misses 1093 1094 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jul 17, 2023
…orch#460) Summary: Pull Request resolved: pytorch#460 Reviewed By: daniellepintz, rohan-varma Differential Revision: D47473960 fbshipit-source-id: 728a57f5df5af78318be76d2c8830630fabf3e67
JKSenthil
force-pushed
the
export-D47473960
branch
from
f3cd143 to
bed9206
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47473960 |
…orch#460) Summary: Pull Request resolved: pytorch#460 Reviewed By: daniellepintz, rohan-varma Differential Revision: D47473960 fbshipit-source-id: 6b8e943fb2e8bca40eb1b6542d6608078c3629d4
|
This pull request was exported from Phabricator. Differential Revision: D47473960 |
JKSenthil
force-pushed
the
export-D47473960
branch
from
bed9206 to
39ad037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed By: daniellepintz, rohan-varma
Differential Revision: D47473960