Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate meta callbacks and oss callbacks in docs #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Jul 2, 2023

Differential Revision: D46847563

Summary: Instead of having two sections for callbacks in the docs, one for OSS and one for Meta we can combine these into one section for better discoverability of callbacks. The one downside of this change is it exposes some Meta-internal names to OSS.

Differential Revision: D46847563

fbshipit-source-id: 6b03c0885199188d3cb6456cde4752a37a56e1a5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46847563

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #438 (262beee) into master (1297517) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files          93       93           
  Lines        7285     7285           
=======================================
  Hits         6312     6312           
  Misses        973      973           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants