Fix module to device in AutoUnit #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbshipit-source-id: d6e1566f82fb798d486f79fb2d72acbcc2881b8a
Summary:
In D46001765 the `self.device` reference was accidentally changed to `device`. Because of this the module isn't being moved to the device properly and we are seeing errors like:
```
ValueError: DistributedDataParallel device_ids and output_device arguments only work with single-device/multiple-device GPU modules or CPU modules, but got device_ids [1], output_device None, and module parameters {device(type='cpu')}
```
when running vise DDP.
Differential Revision: D46056924
fbshipit-source-id: ce22d1efb542b57b951430f0c75d6b075b0e956e
|
This pull request was exported from Phabricator. Differential Revision: D46056924 |
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
- Coverage 86.79% 86.78% -0.02%
==========================================
Files 92 92
Lines 6734 6736 +2
==========================================
+ Hits 5845 5846 +1
- Misses 889 890 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In D46001765 the
self.devicereference was accidentally changed todevice. Because of this the module isn't being moved to the device properly and we are seeing errors like:when running vise DDP.
Differential Revision: D46056924