Switch Nova wheel builds to OIDC #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
huydhn
changed the title
atalman
approved these changes
Jan 11, 2024
malfet
approved these changes
Jan 11, 2024
huydhn
added a commit
to huydhn/audio
that referenced
this pull request
Jan 11, 2024
This is not needed anymore after pytorch/test-infra#4865
huydhn
added a commit
to huydhn/vision
that referenced
this pull request
Jan 11, 2024
This is not needed anymore after pytorch/test-infra#4865.
atalman
pushed a commit
to atalman/test-infra
that referenced
this pull request
Jan 11, 2024
Learn from the previous attempt pytorch#4842: * [x] Keep the secrets param for now till we clean up all domains workflow. * [x] The role `gha_workflow_build_wheels` needs to come from pytorch account instead of fbossci (D52679407) * [x] Per @malfet suggestion, I'm splitting the role into one for nightly and one for test. They require different ref conditions anyway. * [ ] I'll move the uploading part to a separate job in a separate PR to keep this one simple.
This was referenced Jan 12, 2024
huydhn
added a commit
that referenced
this pull request
Jan 12, 2024
This needs to be add to the test workflows after #4865
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Jan 12, 2024
Summary: This fixes the failures when building torchrec wheel using Nova build job. Note that the credential `AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID` has been revoked and we are not using it anymore. I can see it is still used in `.github/workflows/release_build.yml`, so please take priority action to: * Either switch to ODIC like how we do it in Nova pytorch/test-infra#4865. Please reach out to me if you need help on this. * Or remove the workflow if it has been replaced by Nova. Pull Request resolved: #1626 Reviewed By: henrylhtsang Differential Revision: D52737705 Pulled By: huydhn fbshipit-source-id: 79254f42666c6a444973a6d9bd5c13c43ebed0f6
huydhn
added a commit
to huydhn/audio
that referenced
this pull request
Jan 12, 2024
Summary: This is not needed anymore after pytorch/test-infra#4865. Reviewed By: malfet, huydhn, jeanschmidt, clee2000, NicolasHug Differential Revision: D52735187 Pulled By: atalman
huydhn
added a commit
to huydhn/audio
that referenced
this pull request
Jan 12, 2024
Summary: This is not needed anymore after pytorch/test-infra#4865. Reviewed By: malfet, jeanschmidt, clee2000, NicolasHug Differential Revision: D52735187 Pulled By: huydhn
huydhn
added a commit
to pytorch/audio
that referenced
this pull request
Jan 12, 2024
Summary: This is not needed anymore after pytorch/test-infra#4865. Reviewed By: malfet, jeanschmidt, clee2000, NicolasHug Differential Revision: D52735187 Pulled By: huydhn
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
This needs to be add to the test workflows after #4865
atalman
pushed a commit
to atalman/audio
that referenced
this pull request
Feb 12, 2024
Summary: This is not needed anymore after pytorch/test-infra#4865. Reviewed By: malfet, jeanschmidt, clee2000, NicolasHug Differential Revision: D52735187 Pulled By: huydhn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learn from the previous attempt #4842:
gha_workflow_build_wheelsneeds to come from pytorch account instead of fbossci (D52679407)