Skip to content

Use shareable calculate-docker-image GHA #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Use shareable calculate-docker-image GHA #4399

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d7229d
Use shareable calculate-docker-image GHA
huydhn Jul 17, 2023
fddddfc
Run calculate-docker-image after checkout
huydhn Jul 17, 2023
3dc8a02
Pass the working directory
huydhn Jul 18, 2023
8dc462d
Set DOCKER_IMAGE env variable
huydhn Jul 18, 2023
8934378
Merge branch 'main' into use-shareable-gha-calculate-docker-image
huydhn Jul 19, 2023
800e583
Switch to the correct version
huydhn Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions .github/workflows/linux_job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ on:
description: Identifies the Docker image by name.
default: "pytorch/conda-builder"
type: string
docker-build-dir:
description: |
The directory containing the build.sh shell script to build the docker image. The
path is relative to where the repo is checked out.
default: ".ci/docker"
type: string
gpu-arch-type:
description: "GPU arch type to use"
default: "cpu"
Expand Down Expand Up @@ -138,11 +144,6 @@ jobs:
with:
github-secret: ${{ github.token }}

- name: Pull docker image
uses: ./test-infra/.github/actions/pull-docker-image
with:
docker-image: ${{ env.DOCKER_IMAGE }}

- name: Checkout repository (${{ inputs.repository || github.repository }}@${{ inputs.ref }})
uses: actions/checkout@v3
with:
Expand All @@ -152,6 +153,20 @@ jobs:
path: ${{ inputs.repository || github.repository }}
fetch-depth: ${{ inputs.fetch-depth }}

- name: Calculate docker image
id: calculate-docker-image
uses: huydhn/test-infra/.github/actions/calculate-docker-image@calculate-docker-image
with:
docker-image-name: ${{ env.DOCKER_IMAGE }}
docker-build-dir: ${{ inputs.docker-build-dir }}
# This needs to be where the repository is checked out
working-directory: ${{ inputs.repository || github.repository }}

- name: Pull docker image
uses: ./test-infra/.github/actions/pull-docker-image
with:
docker-image: ${{ steps.calculate-docker-image.outputs.docker-image }}

- name: Download artifacts (if any)
uses: actions/download-artifact@v3
if: ${{ inputs.download-artifact != '' }}
Expand All @@ -172,6 +187,7 @@ jobs:
working-directory: ${{ inputs.repository }}
env:
ALL_SECRETS: ${{ toJSON(secrets) }}
DOCKER_IMAGE: ${{ steps.calculate-docker-image.outputs.docker-image }}
run: |
set -ex
{
Expand Down