Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torchserve-kfs docker images for other python version (3.10+) #3374

Open
cjidboon94 opened this issue Dec 12, 2024 · 1 comment
Open

Torchserve-kfs docker images for other python version (3.10+) #3374

cjidboon94 opened this issue Dec 12, 2024 · 1 comment

Comments

@cjidboon94
Copy link

🚀 The feature

torchserve-kfs (and perhaps also torchserve) docker images for different python versions

Motivation, pitch

All the torchserve-kfs docker images are currently built with python 3.9.
For users who base their custom images on this image and have dependencies that require 3.10+, this means they can't easily just run an additional pip install command and are required to install a new/additional python version into their custom image or just build the image from scratch.

Also python version 3.9 ends nears its end of life in less than a year (EOL is 2025-10), so this is a good opportunity to make this available.

Alternatives

Either let the user install an additional python version in the image or let the user write a custom image from scratch.
A ready base image with base dependencies + python version would be much more convenient for this

Additional context

No response

@fabridamicelli
Copy link
Contributor

Here's a cron job that achieves this by running build_image.sh with a matrix of torchserve&python versions values:
https://github.com/fabridamicelli/torchserve-docker

The images live here: https://hub.docker.com/r/fabridamicelli/torchserve/tags

I'd be happy to help integrate this into pytorch/serve, since I believe it would be much better in sync with the rest of the repo there (currently the cron job checks out the repo and git resets hard to the release tag).
I think it would be easier on each release to run that matrix and have all images under the same organization/dockerhubrepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants