Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] _DataCollector -> DataCollectorBase #985

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[Feature] _DataCollector -> DataCollectorBase #985

merged 2 commits into from
Mar 23, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Mar 23, 2023 •
edited

Description

Renames _ DataCollector in DataCollectorBase

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2023
@vmoens vmoens changed the title [Feature] Make DataCollector public [Feature] _DataCollector -> DataCollectorBase Mar 23, 2023
@vmoens vmoens added the Refactoring Refactoring of an existing feature label Mar 23, 2023
@vmoens vmoens merged commit 0d0879c into main Mar 23, 2023
@vmoens vmoens deleted the rename_private branch March 23, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmoens @facebook-github-bot