Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Binary spec inherits from discrete spec #984

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[Refactor] Binary spec inherits from discrete spec #984

merged 2 commits into from
Mar 23, 2023

Conversation

matteobettini
Copy link
Contributor

Tackles #980

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2023
vmoens
vmoens approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens changed the title Binary spec inherits from discrete spec [Refactor] Binary spec inherits from discrete spec Mar 23, 2023
@vmoens vmoens merged commit 893cffc into pytorch:main Mar 23, 2023
@matteobettini matteobettini deleted the binary_spec branch March 24, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matteobettini @vmoens @facebook-github-bot