-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI, Doc] Update functorch source installation command #446
Conversation
Looks like PyTorch didn't publish a nightly binary for mac yet, so this PR will have to wait until then |
4ca3d58
to
fc02322
Compare
Wonderful! We'll need to update the readme.md and contributing.md accordingly I guess. EDIT: macos still failing :/ |
Looks like the torchtext/torchvision nightlies have the 20220913 torch binary as a dependency. Should be fixed tomorrow, so will wait another day.
Yup I can do that in this PR.
It should, but we have not tested functorch extensively on M1 yet. There's a high probability that it works correctly on M1 but we'll add explicit tests soon. EDIT: after reading your readme and seeing that it may be difficult to install functorch on M1 correctly -- I am going to go test functorch on M1 first and then come back here |
fc02322
to
8311a72
Compare
Confirmed that installing PyTorch from source on an M1 machine also installs functorch. So yes, we have M1 support now. |
We changed how one installs functorch: functorch is now included in the PyTorch binary. This PR removes the old installation command which effectively does nothing right now. We'll be removing support for the old installation command after we migrate people off of it. Test Plan: - wait for CI
8311a72
to
5146f83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for this @zou3519!
We changed how one installs functorch: functorch is now included in the PyTorch binary. This PR removes the old installation command which effectively does nothing right now. We'll be removing support for the old installation command after we migrate people off of it.
Test Plan: