[CI, Doc] Update functorch source installation command #446
Conversation
facebook-github-bot
added
the
CLA Signed
|
Looks like PyTorch didn't publish a nightly binary for mac yet, so this PR will have to wait until then |
zou3519
force-pushed
the
update_functorch_nightly_install
branch
from
4ca3d58
to
fc02322
Compare
|
Wonderful! We'll need to update the readme.md and contributing.md accordingly I guess. EDIT: macos still failing :/ |
Looks like the torchtext/torchvision nightlies have the 20220913 torch binary as a dependency. Should be fixed tomorrow, so will wait another day.
Yup I can do that in this PR.
It should, but we have not tested functorch extensively on M1 yet. There's a high probability that it works correctly on M1 but we'll add explicit tests soon. EDIT: after reading your readme and seeing that it may be difficult to install functorch on M1 correctly -- I am going to go test functorch on M1 first and then come back here |
zou3519
force-pushed
the
update_functorch_nightly_install
branch
from
fc02322
to
8311a72
Compare
Confirmed that installing PyTorch from source on an M1 machine also installs functorch. So yes, we have M1 support now. |
vmoens
changed the title
We changed how one installs functorch: functorch is now included in the PyTorch binary. This PR removes the old installation command which effectively does nothing right now. We'll be removing support for the old installation command after we migrate people off of it. Test Plan: - wait for CI
zou3519
force-pushed
the
update_functorch_nightly_install
branch
from
8311a72
to
5146f83
Compare
We changed how one installs functorch: functorch is now included in the PyTorch binary. This PR removes the old installation command which effectively does nothing right now. We'll be removing support for the old installation command after we migrate people off of it.
Test Plan: