Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Remove warnings in test_cost #1902

Merged
merged 8 commits into from
Feb 12, 2024
Merged

[Minor] Remove warnings in test_cost #1902

merged 8 commits into from
Feb 12, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 12, 2024 •
edited

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 12, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1902

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit a53ff3c with merge base 69d44f5 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1410s 67.3185ms 14.8548 Ops/s 15.7347 Ops/s $\textbf{\color{#d91a1a}-5.59\%}$
test_sync 35.6168ms 34.0076ms 29.4051 Ops/s 28.8011 Ops/s $\color{#35bf28}+2.10\%$
test_async 61.1025ms 33.5657ms 29.7923 Ops/s 30.5066 Ops/s $\color{#d91a1a}-2.34\%$
test_simple 0.4942s 0.4314s 2.3181 Ops/s 2.2676 Ops/s $\color{#35bf28}+2.23\%$
test_transformed 0.6627s 0.5967s 1.6760 Ops/s 1.6541 Ops/s $\color{#35bf28}+1.32\%$
test_serial 1.4567s 1.3965s 0.7161 Ops/s 0.6926 Ops/s $\color{#35bf28}+3.39\%$
test_parallel 1.4454s 1.3808s 0.7242 Ops/s 0.7125 Ops/s $\color{#35bf28}+1.65\%$
test_step_mdp_speed[True-True-True-True-True] 0.1648ms 21.6764μs 46.1331 KOps/s 47.0150 KOps/s $\color{#d91a1a}-1.88\%$
test_step_mdp_speed[True-True-True-True-False] 43.7520μs 13.1997μs 75.7592 KOps/s 76.0236 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[True-True-True-False-True] 33.9240μs 12.4558μs 80.2836 KOps/s 79.8042 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[True-True-True-False-False] 35.8280μs 7.6302μs 131.0577 KOps/s 131.9012 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[True-True-False-True-True] 52.6390μs 22.7801μs 43.8980 KOps/s 44.3662 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-True-False-True-False] 49.2230μs 14.4666μs 69.1247 KOps/s 69.2862 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-True-False-False-True] 58.9510μs 13.8501μs 72.2016 KOps/s 73.0184 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[True-True-False-False-False] 57.2280μs 8.8554μs 112.9253 KOps/s 113.2769 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[True-False-True-True-True] 51.1070μs 24.4059μs 40.9737 KOps/s 42.0971 KOps/s $\color{#d91a1a}-2.67\%$
test_step_mdp_speed[True-False-True-True-False] 62.5370μs 15.7419μs 63.5247 KOps/s 63.2863 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[True-False-True-False-True] 50.3840μs 13.7972μs 72.4786 KOps/s 72.7115 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[True-False-True-False-False] 40.4760μs 8.9300μs 111.9824 KOps/s 113.1581 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-False-False-True-True] 64.8820μs 25.3681μs 39.4196 KOps/s 40.3588 KOps/s $\color{#d91a1a}-2.33\%$
test_step_mdp_speed[True-False-False-True-False] 51.5160μs 16.9602μs 58.9617 KOps/s 59.2575 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-False-False-False-True] 41.1570μs 15.0306μs 66.5309 KOps/s 67.8172 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[True-False-False-False-False] 44.7440μs 10.0831μs 99.1758 KOps/s 101.1023 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[False-True-True-True-True] 57.2680μs 24.0771μs 41.5332 KOps/s 41.5930 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[False-True-True-True-False] 48.5410μs 15.7570μs 63.4638 KOps/s 63.9244 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-True-True-False-True] 54.1320μs 16.0895μs 62.1525 KOps/s 62.6949 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[False-True-True-False-False] 58.7010μs 10.2237μs 97.8116 KOps/s 99.8561 KOps/s $\color{#d91a1a}-2.05\%$
test_step_mdp_speed[False-True-False-True-True] 53.8820μs 25.7265μs 38.8704 KOps/s 39.6190 KOps/s $\color{#d91a1a}-1.89\%$
test_step_mdp_speed[False-True-False-True-False] 46.2880μs 16.9111μs 59.1327 KOps/s 59.2055 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[False-True-False-False-True] 45.2750μs 17.2695μs 57.9055 KOps/s 58.8471 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[False-True-False-False-False] 52.2390μs 11.2609μs 88.8029 KOps/s 88.9332 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[False-False-True-True-True] 58.2600μs 26.7045μs 37.4469 KOps/s 38.1684 KOps/s $\color{#d91a1a}-1.89\%$
test_step_mdp_speed[False-False-True-True-False] 42.9610μs 18.2234μs 54.8745 KOps/s 55.0213 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[False-False-True-False-True] 45.7660μs 17.2414μs 57.9998 KOps/s 59.1479 KOps/s $\color{#d91a1a}-1.94\%$
test_step_mdp_speed[False-False-True-False-False] 36.8790μs 11.3870μs 87.8194 KOps/s 89.3791 KOps/s $\color{#d91a1a}-1.75\%$
test_step_mdp_speed[False-False-False-True-True] 0.1094ms 27.8474μs 35.9100 KOps/s 36.6475 KOps/s $\color{#d91a1a}-2.01\%$
test_step_mdp_speed[False-False-False-True-False] 47.5700μs 19.3264μs 51.7428 KOps/s 52.0908 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[False-False-False-False-True] 64.2210μs 18.0959μs 55.2611 KOps/s 54.7554 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-False-False-False-False] 47.7800μs 12.4091μs 80.5860 KOps/s 80.6386 KOps/s $\color{#d91a1a}-0.07\%$
test_values[generalized_advantage_estimate-True-True] 10.7989ms 9.7036ms 103.0544 Ops/s 105.8131 Ops/s $\color{#d91a1a}-2.61\%$
test_values[vec_generalized_advantage_estimate-True-True] 40.7139ms 35.6520ms 28.0489 Ops/s 29.7901 Ops/s $\textbf{\color{#d91a1a}-5.84\%}$
test_values[td0_return_estimate-False-False] 0.2218ms 0.1824ms 5.4812 KOps/s 5.3352 KOps/s $\color{#35bf28}+2.74\%$
test_values[td1_return_estimate-False-False] 24.1650ms 23.7410ms 42.1212 Ops/s 42.1426 Ops/s $\color{#d91a1a}-0.05\%$
test_values[vec_td1_return_estimate-False-False] 42.0868ms 35.9787ms 27.7942 Ops/s 29.7567 Ops/s $\textbf{\color{#d91a1a}-6.59\%}$
test_values[td_lambda_return_estimate-True-False] 36.5132ms 33.7257ms 29.6510 Ops/s 29.4007 Ops/s $\color{#35bf28}+0.85\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.0518ms 35.5269ms 28.1477 Ops/s 29.4660 Ops/s $\color{#d91a1a}-4.47\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.1967ms 8.2157ms 121.7177 Ops/s 122.7084 Ops/s $\color{#d91a1a}-0.81\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3488ms 1.9396ms 515.5571 Ops/s 510.4136 Ops/s $\color{#35bf28}+1.01\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4164ms 0.3509ms 2.8498 KOps/s 2.9023 KOps/s $\color{#d91a1a}-1.81\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 40.1538ms 39.2337ms 25.4883 Ops/s 25.5549 Ops/s $\color{#d91a1a}-0.26\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.2262ms 3.0455ms 328.3527 Ops/s 332.2371 Ops/s $\color{#d91a1a}-1.17\%$
test_dqn_speed 1.7973ms 1.3663ms 731.9293 Ops/s 737.3568 Ops/s $\color{#d91a1a}-0.74\%$
test_ddpg_speed 3.4330ms 2.7462ms 364.1389 Ops/s 365.7552 Ops/s $\color{#d91a1a}-0.44\%$
test_sac_speed 10.1855ms 8.6171ms 116.0484 Ops/s 118.0166 Ops/s $\color{#d91a1a}-1.67\%$
test_redq_speed 14.6361ms 13.5959ms 73.5516 Ops/s 72.5432 Ops/s $\color{#35bf28}+1.39\%$
test_redq_deprec_speed 15.8058ms 14.3487ms 69.6928 Ops/s 71.2088 Ops/s $\color{#d91a1a}-2.13\%$
test_td3_speed 10.0377ms 8.9791ms 111.3694 Ops/s 114.6358 Ops/s $\color{#d91a1a}-2.85\%$
test_cql_speed 39.2269ms 37.6567ms 26.5557 Ops/s 26.9797 Ops/s $\color{#d91a1a}-1.57\%$
test_a2c_speed 9.2411ms 8.0078ms 124.8790 Ops/s 131.1089 Ops/s $\color{#d91a1a}-4.75\%$
test_ppo_speed 8.6536ms 7.8412ms 127.5310 Ops/s 122.7406 Ops/s $\color{#35bf28}+3.90\%$
test_reinforce_speed 8.0150ms 6.7075ms 149.0869 Ops/s 147.9201 Ops/s $\color{#35bf28}+0.79\%$
test_iql_speed 35.3248ms 33.8596ms 29.5338 Ops/s 29.6780 Ops/s $\color{#d91a1a}-0.49\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2832ms 2.9740ms 336.2521 Ops/s 341.5799 Ops/s $\color{#d91a1a}-1.56\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7644ms 0.5157ms 1.9392 KOps/s 1.9280 KOps/s $\color{#35bf28}+0.58\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5987ms 0.4872ms 2.0524 KOps/s 2.0199 KOps/s $\color{#35bf28}+1.61\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3786ms 3.0592ms 326.8880 Ops/s 336.7576 Ops/s $\color{#d91a1a}-2.93\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7189ms 0.5188ms 1.9276 KOps/s 1.9253 KOps/s $\color{#35bf28}+0.12\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7110ms 0.4934ms 2.0268 KOps/s 2.0185 KOps/s $\color{#35bf28}+0.41\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2656ms 2.9588ms 337.9789 Ops/s 331.8579 Ops/s $\color{#35bf28}+1.84\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8469ms 0.6340ms 1.5772 KOps/s 1.5382 KOps/s $\color{#35bf28}+2.53\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7987ms 0.6181ms 1.6178 KOps/s 1.6509 KOps/s $\color{#d91a1a}-2.01\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2649ms 2.9209ms 342.3631 Ops/s 347.5307 Ops/s $\color{#d91a1a}-1.49\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6367ms 0.5176ms 1.9319 KOps/s 1.8999 KOps/s $\color{#35bf28}+1.68\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7182ms 0.5017ms 1.9933 KOps/s 2.0176 KOps/s $\color{#d91a1a}-1.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.4164ms 2.9512ms 338.8399 Ops/s 338.5581 Ops/s $\color{#35bf28}+0.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6651ms 0.5180ms 1.9303 KOps/s 1.8846 KOps/s $\color{#35bf28}+2.43\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7518ms 0.5001ms 1.9994 KOps/s 2.0252 KOps/s $\color{#d91a1a}-1.27\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3323ms 3.1016ms 322.4095 Ops/s 342.4211 Ops/s $\textbf{\color{#d91a1a}-5.84\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9022ms 0.6483ms 1.5424 KOps/s 1.5672 KOps/s $\color{#d91a1a}-1.59\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8879ms 0.6109ms 1.6370 KOps/s 1.6260 KOps/s $\color{#35bf28}+0.68\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1133s 8.4170ms 118.8074 Ops/s 119.4196 Ops/s $\color{#d91a1a}-0.51\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.8938ms 13.4246ms 74.4901 Ops/s 71.4370 Ops/s $\color{#35bf28}+4.27\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.7278ms 2.5507ms 392.0483 Ops/s 394.8643 Ops/s $\color{#d91a1a}-0.71\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1217s 8.7434ms 114.3714 Ops/s 120.6470 Ops/s $\textbf{\color{#d91a1a}-5.20\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1270s 15.7070ms 63.6659 Ops/s 74.2089 Ops/s $\textbf{\color{#d91a1a}-14.21\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.7130ms 2.5742ms 388.4735 Ops/s 387.7996 Ops/s $\color{#35bf28}+0.17\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1177s 9.0708ms 110.2443 Ops/s 92.9373 Ops/s $\textbf{\color{#35bf28}+18.62\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.7948ms 13.9435ms 71.7181 Ops/s 73.4656 Ops/s $\color{#d91a1a}-2.38\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.4188ms 2.8192ms 354.7063 Ops/s 357.2157 Ops/s $\color{#d91a1a}-0.70\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1171s 0.1149s 8.7054 Ops/s 8.6039 Ops/s $\color{#35bf28}+1.18\%$
test_sync 0.1727s 0.1026s 9.7500 Ops/s 9.7508 Ops/s $-0.01\%$
test_async 0.1817s 91.7403ms 10.9003 Ops/s 10.9016 Ops/s $\color{#d91a1a}-0.01\%$
test_single_pixels 0.1360s 0.1358s 7.3627 Ops/s 7.4709 Ops/s $\color{#d91a1a}-1.45\%$
test_sync_pixels 79.2264ms 76.8151ms 13.0183 Ops/s 12.7874 Ops/s $\color{#35bf28}+1.81\%$
test_async_pixels 0.1417s 71.3049ms 14.0243 Ops/s 14.0062 Ops/s $\color{#35bf28}+0.13\%$
test_simple 0.8866s 0.8138s 1.2288 Ops/s 1.2051 Ops/s $\color{#35bf28}+1.97\%$
test_transformed 1.1296s 1.0638s 0.9400 Ops/s 0.9237 Ops/s $\color{#35bf28}+1.77\%$
test_serial 2.4624s 2.4343s 0.4108 Ops/s 0.4144 Ops/s $\color{#d91a1a}-0.87\%$
test_parallel 2.1476s 2.0406s 0.4900 Ops/s 0.4834 Ops/s $\color{#35bf28}+1.38\%$
test_step_mdp_speed[True-True-True-True-True] 0.1049ms 34.0928μs 29.3317 KOps/s 29.2480 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-True-True-True-False] 34.2810μs 20.4177μs 48.9772 KOps/s 49.7976 KOps/s $\color{#d91a1a}-1.65\%$
test_step_mdp_speed[True-True-True-False-True] 41.9010μs 18.8418μs 53.0734 KOps/s 52.8709 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[True-True-True-False-False] 27.0710μs 11.4972μs 86.9780 KOps/s 87.6304 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[True-True-False-True-True] 58.7520μs 35.6447μs 28.0546 KOps/s 27.6437 KOps/s $\color{#35bf28}+1.49\%$
test_step_mdp_speed[True-True-False-True-False] 44.8910μs 21.7585μs 45.9591 KOps/s 45.4763 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[True-True-False-False-True] 45.1200μs 20.6349μs 48.4615 KOps/s 47.8310 KOps/s $\color{#35bf28}+1.32\%$
test_step_mdp_speed[True-True-False-False-False] 37.6200μs 13.3606μs 74.8470 KOps/s 75.0096 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[True-False-True-True-True] 58.9300μs 37.4712μs 26.6872 KOps/s 26.2790 KOps/s $\color{#35bf28}+1.55\%$
test_step_mdp_speed[True-False-True-True-False] 42.0100μs 24.0898μs 41.5113 KOps/s 41.2571 KOps/s $\color{#35bf28}+0.62\%$
test_step_mdp_speed[True-False-True-False-True] 41.3510μs 20.9378μs 47.7605 KOps/s 47.6518 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-False-True-False-False] 37.9910μs 13.4456μs 74.3737 KOps/s 75.2548 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[True-False-False-True-True] 61.2000μs 39.5053μs 25.3130 KOps/s 25.0600 KOps/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[True-False-False-True-False] 41.6110μs 25.8254μs 38.7216 KOps/s 38.6148 KOps/s $\color{#35bf28}+0.28\%$
test_step_mdp_speed[True-False-False-False-True] 40.5710μs 22.5111μs 44.4224 KOps/s 44.6478 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-False-False-False-False] 34.3190μs 15.1543μs 65.9877 KOps/s 66.6462 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[False-True-True-True-True] 60.8410μs 37.5996μs 26.5961 KOps/s 26.8097 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[False-True-True-True-False] 38.0610μs 23.9664μs 41.7250 KOps/s 41.9581 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[False-True-True-False-True] 51.2710μs 25.1173μs 39.8131 KOps/s 40.2235 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[False-True-True-False-False] 39.8110μs 15.2035μs 65.7742 KOps/s 64.6197 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[False-True-False-True-True] 64.4620μs 39.5987μs 25.2534 KOps/s 25.1760 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-True-False-True-False] 45.8110μs 26.0785μs 38.3458 KOps/s 38.9287 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[False-True-False-False-True] 52.5900μs 27.0459μs 36.9742 KOps/s 37.7926 KOps/s $\color{#d91a1a}-2.17\%$
test_step_mdp_speed[False-True-False-False-False] 41.8710μs 17.1107μs 58.4429 KOps/s 58.4923 KOps/s $\color{#d91a1a}-0.08\%$
test_step_mdp_speed[False-False-True-True-True] 66.8510μs 41.2347μs 24.2514 KOps/s 24.0919 KOps/s $\color{#35bf28}+0.66\%$
test_step_mdp_speed[False-False-True-True-False] 52.5600μs 27.6056μs 36.2245 KOps/s 35.5298 KOps/s $\color{#35bf28}+1.96\%$
test_step_mdp_speed[False-False-True-False-True] 52.1910μs 27.0099μs 37.0235 KOps/s 37.3048 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[False-False-True-False-False] 37.9000μs 16.9936μs 58.8456 KOps/s 59.7053 KOps/s $\color{#d91a1a}-1.44\%$
test_step_mdp_speed[False-False-False-True-True] 68.1300μs 42.6608μs 23.4407 KOps/s 23.1410 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[False-False-False-True-False] 55.5810μs 29.2650μs 34.1706 KOps/s 33.7296 KOps/s $\color{#35bf28}+1.31\%$
test_step_mdp_speed[False-False-False-False-True] 44.9210μs 28.0652μs 35.6313 KOps/s 35.6450 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-False-False-False-False] 41.5810μs 18.8032μs 53.1823 KOps/s 52.7653 KOps/s $\color{#35bf28}+0.79\%$
test_values[generalized_advantage_estimate-True-True] 25.9957ms 25.0395ms 39.9368 Ops/s 43.1092 Ops/s $\textbf{\color{#d91a1a}-7.36\%}$
test_values[vec_generalized_advantage_estimate-True-True] 83.3419ms 3.2189ms 310.6610 Ops/s 300.3688 Ops/s $\color{#35bf28}+3.43\%$
test_values[td0_return_estimate-False-False] 0.1002ms 59.5915μs 16.7809 KOps/s 16.7761 KOps/s $\color{#35bf28}+0.03\%$
test_values[td1_return_estimate-False-False] 55.5395ms 54.5534ms 18.3307 Ops/s 19.7805 Ops/s $\textbf{\color{#d91a1a}-7.33\%}$
test_values[vec_td1_return_estimate-False-False] 2.1039ms 1.7430ms 573.7191 Ops/s 572.3210 Ops/s $\color{#35bf28}+0.24\%$
test_values[td_lambda_return_estimate-True-False] 82.2621ms 81.5478ms 12.2627 Ops/s 12.3102 Ops/s $\color{#d91a1a}-0.39\%$
test_values[vec_td_lambda_return_estimate-True-False] 3.9751ms 1.7962ms 556.7289 Ops/s 561.5911 Ops/s $\color{#d91a1a}-0.87\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.7805ms 23.2781ms 42.9589 Ops/s 44.6478 Ops/s $\color{#d91a1a}-3.78\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8664ms 0.6891ms 1.4513 KOps/s 1.4498 KOps/s $\color{#35bf28}+0.10\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6954ms 0.6381ms 1.5671 KOps/s 1.5509 KOps/s $\color{#35bf28}+1.05\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4706ms 1.4403ms 694.3062 Ops/s 691.3265 Ops/s $\color{#35bf28}+0.43\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9443ms 0.6550ms 1.5268 KOps/s 1.5142 KOps/s $\color{#35bf28}+0.83\%$
test_dqn_speed 7.9536ms 1.4460ms 691.5829 Ops/s 703.5422 Ops/s $\color{#d91a1a}-1.70\%$
test_ddpg_speed 3.1355ms 2.7128ms 368.6180 Ops/s 366.7770 Ops/s $\color{#35bf28}+0.50\%$
test_sac_speed 8.6804ms 8.2853ms 120.6957 Ops/s 120.3222 Ops/s $\color{#35bf28}+0.31\%$
test_redq_speed 11.2071ms 10.4401ms 95.7844 Ops/s 94.3251 Ops/s $\color{#35bf28}+1.55\%$
test_redq_deprec_speed 11.7117ms 11.2397ms 88.9707 Ops/s 86.3721 Ops/s $\color{#35bf28}+3.01\%$
test_td3_speed 17.5505ms 8.4497ms 118.3472 Ops/s 117.5426 Ops/s $\color{#35bf28}+0.68\%$
test_cql_speed 25.4483ms 25.0598ms 39.9046 Ops/s 39.1840 Ops/s $\color{#35bf28}+1.84\%$
test_a2c_speed 5.5337ms 5.2816ms 189.3370 Ops/s 184.3934 Ops/s $\color{#35bf28}+2.68\%$
test_ppo_speed 6.1453ms 5.5754ms 179.3590 Ops/s 176.1945 Ops/s $\color{#35bf28}+1.80\%$
test_reinforce_speed 4.6023ms 4.3799ms 228.3172 Ops/s 222.4135 Ops/s $\color{#35bf28}+2.65\%$
test_iql_speed 20.0183ms 19.5700ms 51.0987 Ops/s 50.9869 Ops/s $\color{#35bf28}+0.22\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7504ms 3.5763ms 279.6171 Ops/s 276.6781 Ops/s $\color{#35bf28}+1.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7116ms 0.5638ms 1.7736 KOps/s 1.7699 KOps/s $\color{#35bf28}+0.21\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7218ms 0.5322ms 1.8791 KOps/s 1.8562 KOps/s $\color{#35bf28}+1.23\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8221ms 3.6393ms 274.7818 Ops/s 278.1896 Ops/s $\color{#d91a1a}-1.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7462ms 0.5557ms 1.7996 KOps/s 1.7884 KOps/s $\color{#35bf28}+0.62\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6928ms 0.5341ms 1.8722 KOps/s 1.8753 KOps/s $\color{#d91a1a}-0.16\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8912ms 3.7558ms 266.2580 Ops/s 267.2168 Ops/s $\color{#d91a1a}-0.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8103ms 0.6845ms 1.4609 KOps/s 1.4428 KOps/s $\color{#35bf28}+1.26\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7847ms 0.6578ms 1.5203 KOps/s 1.5116 KOps/s $\color{#35bf28}+0.57\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6944ms 3.6117ms 276.8783 Ops/s 276.2393 Ops/s $\color{#35bf28}+0.23\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6845ms 0.5633ms 1.7754 KOps/s 1.7383 KOps/s $\color{#35bf28}+2.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7061ms 0.5366ms 1.8637 KOps/s 1.8365 KOps/s $\color{#35bf28}+1.48\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8530ms 3.6666ms 272.7355 Ops/s 274.2167 Ops/s $\color{#d91a1a}-0.54\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7722ms 0.5547ms 1.8027 KOps/s 1.7746 KOps/s $\color{#35bf28}+1.58\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6590ms 0.5299ms 1.8871 KOps/s 1.8590 KOps/s $\color{#35bf28}+1.51\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8651ms 3.7540ms 266.3844 Ops/s 265.6962 Ops/s $\color{#35bf28}+0.26\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8154ms 0.6856ms 1.4586 KOps/s 1.4373 KOps/s $\color{#35bf28}+1.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8514ms 0.6575ms 1.5208 KOps/s 1.5029 KOps/s $\color{#35bf28}+1.19\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1340s 10.2465ms 97.5945 Ops/s 97.2224 Ops/s $\color{#35bf28}+0.38\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.5679ms 16.2605ms 61.4986 Ops/s 60.5106 Ops/s $\color{#35bf28}+1.63\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.6833ms 3.0835ms 324.3034 Ops/s 327.2436 Ops/s $\color{#d91a1a}-0.90\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1182s 9.9578ms 100.4242 Ops/s 99.5056 Ops/s $\color{#35bf28}+0.92\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.5708ms 16.2779ms 61.4329 Ops/s 52.6963 Ops/s $\textbf{\color{#35bf28}+16.58\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.3428ms 3.0803ms 324.6414 Ops/s 327.0524 Ops/s $\color{#d91a1a}-0.74\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1188s 10.1581ms 98.4441 Ops/s 97.0585 Ops/s $\color{#35bf28}+1.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1277s 18.6307ms 53.6747 Ops/s 58.8048 Ops/s $\textbf{\color{#d91a1a}-8.72\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.3724ms 3.4003ms 294.0911 Ops/s 293.9295 Ops/s $\color{#35bf28}+0.05\%$

@vmoens vmoens added bug Something isn't working Tests Incomplete or broken unit tests labels Feb 12, 2024
@vmoens vmoens merged commit 2f9e1ae into main Feb 12, 2024
63 of 67 checks passed
@vmoens vmoens deleted the remove-cost-test-warnings branch February 12, 2024 14:59
@vmoens vmoens added the Suitable for minor Suitable to be integrated in minor release (no new feature) label Feb 12, 2024
vmoens added a commit that referenced this pull request Feb 28, 2024
@vmoens
[Minor] Remove warnings in test_cost (#1902)
8dc96cf
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Suitable for minor Suitable to be integrated in minor release (no new feature) Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmoens @facebook-github-bot