Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add CQL #1239

Merged
merged 12 commits into from
Jun 8, 2023
Merged

[Feature] Add CQL #1239

merged 12 commits into from
Jun 8, 2023

Conversation

BY571
Copy link
Contributor

@BY571 BY571 commented Jun 7, 2023

Description

Implements the Conservative Q-Learning (CQL) objective for Offline Reinforcement Learning (https://arxiv.org/abs/2006.04779)
and adds examples for online and offline training.

Performance tested for Pendulum:
image

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2023
@BY571 BY571 marked this pull request as ready for review June 8, 2023 09:01
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Exciting stuff
A few comments

torchrl/objectives/cql.py Show resolved Hide resolved
torchrl/objectives/cql.py Show resolved Hide resolved
torchrl/objectives/cql.py Show resolved Hide resolved
torchrl/objectives/cql.py Show resolved Hide resolved
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Exciting stuff
A few comments

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesoooome!
let's wait for the tests to pass :)

@BY571
Copy link
Contributor Author

BY571 commented Jun 8, 2023

I'm getting an error now regarding the in_keys of the objective, checking about that!

Fixed!

@vmoens vmoens added the new algo New algorithm request or PR label Jun 8, 2023
@vmoens vmoens merged commit 5e32406 into pytorch:main Jun 8, 2023
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. new algo New algorithm request or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants