Extract DeviceType to a standalone header file #154417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154417
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 Cancelled Jobs, 2 Unrelated FailuresAs of commit 55ac81e with merge base 4fd8a54 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
oncall: jit
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75313723 |
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
May 27, 2025
Summary: X-link: pytorch/pytorch#154417 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of pytorch/pytorch#152787, because we need to land in fbcode first. See the original comments and discussions in pytorch/pytorch#152787. Differential Revision: D75313723
Skylion007
approved these changes
May 27, 2025
desertfire
commented
May 27, 2025
janeyx99
reviewed
May 27, 2025
janeyx99
approved these changes
May 27, 2025
Contributor
janeyx99
left a comment
janeyx99
left a comment
There was a problem hiding this comment.
I'm fine with a flag called TORCH_STANDALONE
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
May 27, 2025
Summary: X-link: pytorch/pytorch#154417 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of pytorch/pytorch#152787, because we need to land in fbcode first. See the original comments and discussions in pytorch/pytorch#152787. Reviewed By: janeyx99 Differential Revision: D75313723
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
May 27, 2025
Summary: X-link: pytorch/pytorch#154417 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of pytorch/pytorch#152787, because we need to land in fbcode first. See the original comments and discussions in pytorch/pytorch#152787. Reviewed By: janeyx99 Differential Revision: D75313723
desertfire
force-pushed
the
export-D75313723
branch
from
df5b453 to
90d1d24
Compare
Summary: X-link: pytorch/executorch#11145 Pull Request resolved: #154417 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of #152787, because we need to land in fbcode first. See the original comments and discussions in #152787. Test Plan: CI Reviewed By: janeyx99 Differential Revision: D75313723
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75313723 |
desertfire
force-pushed
the
export-D75313723
branch
from
90d1d24 to
55ac81e
Compare
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 5 jobs have failed, first few of them are: trunk / cuda12.8-py3.10-gcc9-sm80 / build, inductor / cuda12.8-py3.10-gcc9-sm86 / build, inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / build, inductor / unit-test / cuda12.6-py3.12-gcc9-sm86 / build, inductor / unit-test / cuda12.6-py3.13-gcc9-sm86 / build Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
Unlanded internally. Let's not force-merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does:
This is an updated version of #152787, because we need to land in fbcode first. See the original comments and discussions in #152787.
Test Plan: CI
Differential Revision: D75313723
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel