simplify torch.utils.cpp_extension.include_paths; use it in cpp_builder#145480
simplify torch.utils.cpp_extension.include_paths; use it in cpp_builder#145480h-vetinari wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145480
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 074cb61 with merge base 46e06e1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
@pytorchbot label "topic: not user facing" |
cpuhrsch
added
the
triaged
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -r |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
The /TH headers have not existed since pytorch 1.11
|
Successfully rebased |
pytorchmergebot
force-pushed
the
headers
branch
from
bc2038d to
074cb61
Compare
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…er (pytorch#145480) While working on conda-forge integration, I needed to look at the way the include paths are calculated, and noticed an avoidable duplication between `torch/utils/cpp_extension.py` and `torch/_inductor/cpp_builder.py`. The latter already imports the former anyway, so simply reuse the same function. Furthermore, remove long-obsolete include-paths. AFAICT, the `/TH` headers have not existed since pytorch 1.11. Pull Request resolved: pytorch#145480 Approved by: https://github.com/ezyang
5 participants
While working on conda-forge integration, I needed to look at the way the include paths are calculated, and noticed an avoidable duplication between
torch/utils/cpp_extension.pyandtorch/_inductor/cpp_builder.py. The latter already imports the former anyway, so simply reuse the same function.Furthermore, remove long-obsolete include-paths. AFAICT, the
/THheaders have not existed since pytorch 1.11.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov