Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_accuracy.py to generate data with different random seed #2637

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Update test_accuracy.py to generate data with different random seed #2637

merged 5 commits into from
Aug 15, 2022

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Aug 11, 2022 •
edited
Loading

…er rank

Fixes #{issue number}

Description: Change generating data logic from slicing to different random seed per rank in _test_distrib_integration_multiclass
After this PR, will correct _test_distrib_integration_multilabel and _test_distrib_integration_list_of_tensors_or_numbers

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@puhuk
Update test_accuracy.py to generate data with different random seed p…
6693f9d 
…er rank

Change generating data logic from slicing to different random seed per rank
vfdev-5
vfdev-5 reviewed Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @puhuk

tests/ignite/metrics/test_accuracy.py Show resolved Hide resolved
tests/ignite/metrics/test_accuracy.py Show resolved Hide resolved
tests/ignite/metrics/test_accuracy.py Outdated Show resolved Hide resolved
puhuk and others added 4 commits August 11, 2022 15:35
@puhuk
Update test_accuracy.py
fbad361 
delete duplicated code
change `s` to `batch_size`
eliminate variable `offset`
@puhuk
Update test_accuracy.py
734f626 
Modify `_test_distrib_integration_multilabel` and `_test_distrib_integration_list_of_tensors_or_numbers`
@puhuk
Update test_accuracy.py
96c6e40 
Correct `_test_distrib_integration_multiclass` with correct use of `Engine`
Revert other methods except `_test_distrib_integration_multiclass`
@vfdev-5
Merge branch 'master' into test_accuracy_to_diff_rank
3cdf346
vfdev-5
vfdev-5 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @puhuk

Let's see if CI is passing

@vfdev-5 vfdev-5 merged commit ed13aa9 into pytorch:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puhuk @vfdev-5