Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cm #2618

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Test cm #2618

merged 4 commits into from
Jul 18, 2022

Conversation

kamalojasv181
Copy link
Contributor

@kamalojasv181 kamalojasv181 commented Jul 18, 2022 •
edited
Loading

Related to #2522

Description: Improved tests for tests/ignite/metrics/test_connfusio_matrix.py

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jul 18, 2022 •
edited
Loading

@kamalojasv181 please put into description: Related to #2522 instead of Fixes #2522 such that merging this PR wont close the issue which is rather generic

vfdev-5
vfdev-5 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @kamalojasv181

@kamalojasv181
Copy link
Contributor Author

@vfdev-5 is anything else required? Its good to merge according to me

@vfdev-5 vfdev-5 enabled auto-merge (squash) July 18, 2022 10:57
@vfdev-5 vfdev-5 merged commit 9fca904 into pytorch:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamalojasv181 @vfdev-5