Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RunningAverage usage in doctest #2483

Merged
merged 3 commits into from
Feb 20, 2022
Merged

Fix RunningAverage usage in doctest #2483

merged 3 commits into from
Feb 20, 2022

Conversation

sdesrozis
Copy link
Contributor

Description:

Usually, RunningAverage is used on trainer, however evaluator is used in the doctest.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added docs module: metrics Metrics module labels Feb 19, 2022
vfdev-5
vfdev-5 approved these changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdesrozis

@vfdev-5 vfdev-5 enabled auto-merge (squash) February 20, 2022 00:19
@vfdev-5 vfdev-5 merged commit 7be7094 into pytorch:master Feb 20, 2022
@sdesrozis sdesrozis deleted the doctest_running_average branch February 20, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdesrozis @vfdev-5