-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added links to all the metric files #2474
Conversation
@sayantan1410 thanks for the PR ! Actually, I think we decided a bit too fast about including this text to defaults.rst as now it is associated with metrics, however, we are also using it for certain handlers: @sayantan1410 @DevPranjal Any ideas how to deal with that ? |
@vfdev-5 There are two solutions in my mind :
|
In Idea (2) there could be few difficulties like those we had with defaults.rst (we have to copy it into a specific path to be discovered), we have to ensure that python definitions aren't duplicated and we still have to update all docstring for metrics to rename Idea (1) is more explicit but can be a pain to do... |
@vfdev-5 Not really, I will just have to copy and paste the text to all the metric docstrings !! |
With the above issue, Idea 1. sounds good to me |
@vfdev-5 Hey, I have added the text for all the metric.py files listed here - https://pytorch.org/ignite/metrics.html#complete-list-of-metrics. Let me know if I have missed any. |
@sayantan1410 I provided a temporary CI fix: #2477 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sayantan1410
@vfdev-5 hey, some checks were unsuccessful that's why it did not merge, can you check once why ?? |
@sayantan1410 yes, there is an issue with new release of openai gym and deprecated env cartpole. we have to fix it. |
I think I can merge your PR as failures are unrelated. |
@thanks for closing the PR !! |
@sayantan1410 can you please open an issue describing the failed tests and maybe a fix ? |
@vfdev-5 yeah sure I will do it. |
Fixes #2437
Opened this PR as an extension of this PR #2468, I by mistake lost track of that branch. Apology or the inconvenience. Extremely sorry.
@vfdev-5 @DevPranjal Kindly let me know if the changes are alright for you or I have made some mistake.
Check list: