Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pytest.mark.xfail on test_distrib_gloo_cpu_or_gpu() #2454

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Added pytest.mark.xfail on test_distrib_gloo_cpu_or_gpu() #2454

merged 6 commits into from
Feb 8, 2022

Conversation

nishantb06
Copy link
Contributor

@nishantb06 nishantb06 commented Feb 7, 2022

Fixes #2453

Description:
After correcting the syntax of pytest.approx(), Assertion error was detected due to the values not being the same. Which is why pytest.mark.xfail was added on test_distrib_gloo_cpu_or_gpu()

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 7, 2022

@nishantb06 thanks for the PR, let's xfail all tests in this python file.
xla and hvd tests are also failing: https://github.com/pytorch/ignite/runs/5094361286?check_suite_focus=true#step:9:483

  • test_distrib_hvd
  • test_distrib_xla_nprocs
  • test_distrib_nccl_gpu

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 8, 2022

@nishantb06 thanks for the update, I added manually 2 more xfails to disable all the tests and also restart CI. Let's see if it passes now and we can merge this PR.

@nishantb06
Copy link
Contributor Author

Thank you.

@vfdev-5 vfdev-5 merged commit 9039aeb into pytorch:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled workflow failed
2 participants