Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(contributing): update for make doctest [skip ci] #2278

Merged
merged 4 commits into from
Oct 20, 2021
Merged

chore(contributing): update for make doctest [skip ci] #2278

merged 4 commits into from
Oct 20, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Oct 19, 2021

Description: per title

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ydcjeff ydcjeff mentioned this pull request Oct 19, 2021
Closed
3 tasks
vfdev-5
vfdev-5 reviewed Oct 19, 2021
View reviewed changes
vfdev-5
vfdev-5 reviewed Oct 19, 2021
View reviewed changes
@ydcjeff ydcjeff requested a review from vfdev-5 October 19, 2021 10:27
vfdev-5
vfdev-5 reviewed Oct 19, 2021
View reviewed changes
@ydcjeff ydcjeff force-pushed the contributing-doctest branch from d72b257 to 8cdb514 Compare October 20, 2021 04:20
@ydcjeff ydcjeff requested a review from vfdev-5 October 20, 2021 04:21
vfdev-5
vfdev-5 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ydcjeff

@vfdev-5 vfdev-5 merged commit 4287069 into pytorch:master Oct 20, 2021
@ydcjeff ydcjeff deleted the contributing-doctest branch October 20, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydcjeff @vfdev-5