Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hash_checkpoint): create the directory if not exist #2273

Merged
merged 6 commits into from
Oct 18, 2021
Merged

feat(hash_checkpoint): create the directory if not exist #2273

merged 6 commits into from
Oct 18, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Oct 18, 2021

Description: I forgot to add.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: utils Utils module label Oct 18, 2021
vfdev-5
vfdev-5 reviewed Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few other minor doc tweaks

ignite/utils.py Outdated Show resolved Hide resolved
ignite/utils.py Outdated Show resolved Hide resolved
@ydcjeff ydcjeff requested a review from vfdev-5 October 18, 2021 15:00
vfdev-5
vfdev-5 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 18, 2021

@ydcjeff maybe a test for this feature ?

@ydcjeff ydcjeff requested a review from vfdev-5 October 18, 2021 15:20
vfdev-5
vfdev-5 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@vfdev-5 vfdev-5 enabled auto-merge (squash) October 18, 2021 15:25
auto-merge was automatically disabled October 18, 2021 15:46

Head branch was pushed to by a user without write access

@vfdev-5 vfdev-5 merged commit ed5e1dd into pytorch:master Oct 18, 2021
@ydcjeff ydcjeff deleted the feat/mkdir branch October 18, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: utils Utils module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydcjeff @vfdev-5