-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): add hashing a checkpoint utility #2272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ydcjeff thanks for the PR ! First of all, mypy is not passing on it. I'm hesitating on adding the cmd line tool. I see the benefit but not sure if ignite should provide cmd line tools for the moment. @sdesrozis @trsvchn thoughts ?
@ydcjeff Thanks for this feature ! The |
@vfdev-5 If we are not sure about CLI, we could add it in the future.
@sdesrozis As I stated in the issue, I believe this function is mostly used for the finalized checkpoint, so I am not sure adding another argument in the |
@ydcjeff sounds good, let's scope this PR for python utils method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ydcjeff
fix #2269
Description: Add hashing utility for checkpoint
Check list: