Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2114: make doc subsections header bold #2216

Merged
merged 3 commits into from
Sep 26, 2021
Merged

fix #2114: make doc subsections header bold #2216

merged 3 commits into from
Sep 26, 2021

Conversation

toxa23
Copy link
Contributor

@toxa23 toxa23 commented Sep 25, 2021

Fixes #2114

Description:
part 1 of 7, adding CSS style for docstring section headers

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the docs label Sep 25, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 25, 2021

@ydcjeff please help with reviewing this PR. Thanks!

vfdev-5
vfdev-5 approved these changes Sep 25, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @toxa23
I approve as it looks good to me. Let's see what @ydcjeff says

ydcjeff
ydcjeff approved these changes Sep 26, 2021
View reviewed changes
Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfdev-5 vfdev-5 merged commit ad9bb6a into pytorch:master Sep 26, 2021
@toxa23 toxa23 deleted the fix-2114-bold-doc-section-headers branch September 26, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydcjeff ydcjeff ydcjeff approved these changes

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve doc examples rendering
3 participants
@toxa23 @vfdev-5 @ydcjeff